Ticket #1 (new defect)

Opened 7 years ago

Last modified 7 years ago

graph operations don't detect duplicate-label errors

Reported by: nr Owned by: somebody
Priority: minor Milestone:
Component: component1 Version:
Keywords: Cc:


Hoopl should detect a situation in which two graphs are spliced and the labels of the blocks overlap. At presesent, Hoopl uses Data.IntSet?.mapUnion and Data.IntSet?.insert, neither of which fails if a duplicate label appears. Graph splicing and other code needs to be modified to panic if labels overlap during splicing. We therefore need something like

  unionWithKey (\l _ _ -> panic ("duplicate blocks with label " ++ show l))

and similarly for insertion.

Change History

Changed 7 years ago by nr

I've changed a couple of places---graph splicing and addBlock. See commit a6982760c990cda7b40a79a5cbdc03348ee9c0d6. But it needs review.

Note: See TracTickets for help on using tickets.