Ticket #1164: reversed-toGSList.dpatch

Thu May 14 13:29:33 BST 2009  m.niloc@gmail.com
  * Fix Trac #1164. toGSList was reversing lists.

New patches:

[Fix Trac #1164. toGSList was reversing lists.
m.niloc@gmail.com**20090514122933
 Ignore-this: c466eadbc5ae61ba71721fe15b44735a
] {
hunk ./glib/System/Glib/GList.chs 45
 
 import Foreign
 import Control.Exception       (bracket)
+import Control.Monad           (foldM)
 
 {# context lib="glib" prefix="g" #}
 
hunk ./glib/System/Glib/GList.chs 117
 -- Turn a list of something into a GList.
 --
 toGList :: [Ptr a] -> IO GList
-toGList xs = makeList nullPtr xs
+toGList = foldM prepend nullPtr . reverse
   where
hunk ./glib/System/Glib/GList.chs 119
-    -- makeList :: GList -> [Ptr a] -> IO GList
-    makeList current (x:xs) = do
-      newHead <- {#call unsafe list_prepend#} current (castPtr x)
-      makeList newHead xs
-    makeList current [] = return current
+    -- prepend :: GList -> Ptr a -> IO GList
+    prepend l x = {#call unsafe list_prepend#} l (castPtr x)
 
 -- Turn a list of something into a GSList.
 --
hunk ./glib/System/Glib/GList.chs 125
 toGSList :: [Ptr a] -> IO GSList
-toGSList xs = makeList nullPtr xs
+toGSList = foldM prepend nullPtr . reverse
   where
hunk ./glib/System/Glib/GList.chs 127
-    -- makeList :: GSList -> [Ptr a] -> IO GSList
-    makeList current (x:xs) = do
-      newHead <- {#call unsafe slist_prepend#} current (castPtr x)
-      makeList newHead xs
-    makeList current [] = return current
+    -- prepend :: GSList -> Ptr a -> IO GList
+    prepend l x = {#call unsafe slist_prepend#} l (castPtr x)
 
 -- Temporarily allocate a list of something
 --
}

Context:

[Makefile.am: remove slashes after DESTDIR (fixes trac #1160)
pgavin@gmail.com**20090510180614
 Ignore-this: 5c57aa6375618d627e7568303a36abdd
] 
[TAG 0.10.1
pgavin@gmail.com**20090510160214] 
[configure.ac: bump version to 0.10.1
pgavin@gmail.com**20090429032110
 Ignore-this: 682c3f529251a07b3de0761729af5eeb
] 
[Add missing export of Click(..) data type, repoted by Ben Franksen.
Axel.Simon@ens.fr**20090509184414] 
[gtk/Graphics/UI/Gtk/General/Structs.hsc: Accept responses 0 and smaller than -11.
Marco Túlio Gontijo e Silva <marcot@holoscopio.com>**20090507111848
 Ignore-this: f64b69b52a743ac54b404452178b29c0
] 
[Input method bindings
m.niloc@gmail.com**20090504191302
 Ignore-this: e8cbd55f0519ab413b24cae7b99d7b3d
] 
[Improve apiGen names, for example hsv instead of hSV
m.niloc@gmail.com**20090430152250
 Ignore-this: 89e23bb8809006e40a3708049de9c031
] 
[Bind GtkObject's destroy signal
m.niloc@gmail.com**20090430152124
 Ignore-this: b67612a0e13a5cabc2c3392cb78fadaf
] 
[Add a function to insert the current clipboard content at the current cursor.
Axel Simon <Axel.Simon@ens.fr>**20090424152430] 
[configure.ac: add bz2 dist tarball
pgavin@gmail.com**20090429034820
 Ignore-this: 5dfb2e2e91ab8b991d6908c7c08a51fe
] 
[gtk: OwnerChange event only since gtk 2.6
pgavin@gmail.com**20090429032134
 Ignore-this: 23e3be727b8d43711321accaf35a4bf6
] 
[Fix drawWindowGetPointer, trac #802.
Axel.Simon@ens.fr**20090427194638] 
[Add an Eq instance for all objects.
Axel.Simon@ens.fr**20090426153152
 This patch makes it possible to use == to compare two objects or, rather,
 their pointers. Since for one case an object is merely containing data
 and has its own Eq instance, it was necessary to add a 'noEq' flag to
 the type generator that, when given, prevents the generation of the
 deriving Eq clause. This patch fixes trac #1158.
] 
[New version of carsim demo
mauricio.antunes@gmail.com**20090410234420
 It has been a couple years since I wrote what is now the
 'carsim' gtk2hs demo. I realized many of gtk+, gtk2hs and ghc
 user library have been deprecated and replaced since then.
 As it's in a demo directory, I thought it would be better to
 have an updated version using current recomended API. Except
 for a 'Pause' button, nothing important has changed in the user
 interface. Changes in code include:
 
 - Deprecated code, like System.Time and a few of gtk2hs, has
 been replaced.
 
 - Bug fix in about dialog.
 
 - Use of EventM.
 
 - Code is now UTF-8, but that only affects author name.
 
 - Hopefully, better code and documentation.
] 
[gtk: allow zero as argument to toResponse in G.U.G.General.Structs
pgavin@gmail.com**20090424152136
 Ignore-this: 922761ff9383f47f6efc030377241316
] 
[Unregister packages in reverse order to avoid dependency conflict.
Axel Simon <Axel.Simon@ens.fr>**20090424144710] 
[Makefile.am: add package dependencies to haddock command line
pgavin@gmail.com**20090424022757
 Ignore-this: 4bbe2fde77816e01e7b8be81863cb234
] 
[Correct arguments of a finally statement.
Axel Simon <Axel.Simon@ens.fr>**20090417143511
 This code has obviously never been tested. Thanks to Bertram Felgenhauer to spot this.
] 
[Adapt demo to use new Exception module.
Axel Simon <Axel.Simon@ens.fr>**20090417142437] 
[Add 'clean-all' option to tools/apiGen/Makefile
mauricio.antunes@gmail.com**20090409024158
 This adds a 'clean-all' option to apiGen's make
 file. It will erase everything not on the original
 distribution. This may be usefull if we are
 testing different versions of packages, and need
 to remove tarballs between tests.
] 
[gio: Avoid calling (freeHaskellFunPtr nullFunPtr).
Bertram Felgenhauer <int-e@gmx.de>**20090407084617] 
[Make explicit use of concurrent finalizers.
Axel Simon <Axel.Simon@ens.fr>**20090327110603
 This patch acounts for the change of semantics that finalizers undergo with
 the release of GHC 6.10.1. Specifcially, finalizers are now by default
 run during garbage collection, making it impossible to have them call back
 to Haskell land. This patch uses functions that specifically schedule any
 finilizers to be run as new threads once the mutator springs back to life.
] 
[Add eventClick to EventM
Hamish Mackenzie <hamish@firestream.co.uk>**20090307080530
 Ignore-this: ff7b605b58d6021248f9951b4c641209
] 
[Fix documentation.
Axel.Simon@ens.fr**20090217180909] 
[TAG 0.10.0
Peter Gavin <pgavin@gmail.com>**20090207054815] 
Patch bundle hash:
cbf745437808bdebca70c559d2671aad85e0afd5