Ticket #186 (closed defect: fixed)

Opened 2 years ago

Last modified 19 months ago

invalid xhtml being generated

Reported by: Phyx Owned by: SimonHengel
Priority: major Milestone:
Version: 2.9.2 Keywords:
Cc:

Description

I'm adding a new backend to haddock and am consuming the xhtml being generated by the html backend. While doing so I've (so far) noticed two points where invalid xhtml is being generated:

1) inside Xhtml.hs line 180 "nonEmpty sectionName"

"sectionName" already contains a class attribute, and nonEmpty adds another one (incorrectly). You end up with 'class="caption" class="empty"' instead of 'class="caption empty"'.

I beleive this is an xhtml issue, and have reported it so https://github.com/haskell/xhtml/issues/2 and have for now created a method emptySectionName which outputs the proper classes:

-- | Make a special empty paragraph with the emptySectionName :: Html -> Html emptySectionName entry = paragraph ! [theclass "caption empty"] << (spaceHtml +++ entry)

2) frames.html (the template) is invalid

# <head> is never closed
# <title> is ommitted
# empty <frame> elements are not closed

I've attached a valid one

Attachments

frames.html (0.8 kB) - added by Phyx 2 years ago.

Change History

Changed 2 years ago by Phyx

Changed 2 years ago by SimonHengel

  • owner set to SimonHengel
  • status changed from new to assigned

Changed 2 years ago by waern

  • status changed from assigned to closed
  • resolution set to fixed

Changed 19 months ago by anonymous

  • milestone 2.10.0 deleted

Milestone 2.10.0 deleted

Note: See TracTickets for help on using tickets.