Stop! Tickets are now managed at GitHub.

Please enter new tickets, and find and edit existing tickets there:


Ticket #196 (assigned enhancement)

Opened 2 years ago

Last modified 11 months ago

add DESTDIR parameter to Haskell Platform installer Makefile

Reported by: chrisdornan Owned by: MtnViewMark
Priority: minor Milestone: 2013.2.0.0
Component: Generic source tarball Keywords:
Cc:

Description

When packagers install they usually don't want to install the prepared files but to install into a staging area for packaging. This is usually done by specifying a DESTDIR paramater to 'make install':

make DESTDIR=${RPM_BUILD_ROOT} install

It would be nice if the haskell platform installer could do this.

At the moment I am patching the scripts/install.sh to look out for a DESTDIR file and use the specified directory as the root if it is specified. The package installation scripts get passed back to the installer in $(DESTDIR)/load (see attached script). I am not not necessarily advocating this organization but just use it myself because it keeps the patch restricted to install.sh. I submit it in case somebody else would find it useful.

Attachments

install.sh (2.3 kB) - added by chrisdornan 2 years ago.
install.sh
patch-scripts_install.sh (1.9 kB) - added by AlainODea 11 months ago.
PKGSRC patch for scripts/install.sh (works only for GHC 7.6.3)

Change History

Changed 2 years ago by chrisdornan

install.sh

Changed 2 years ago by MtnViewMark

  • owner changed from duncan to MtnViewMark
  • status changed from new to assigned
  • milestone set to 2013.2.0.0

Changed 11 months ago by AlainODea

I am trying to prepare a PKGSRC package for SmartOS and I'm having this same issue.

DESTDIR support is in the majority of the 11,000 packages currently in PKGSRC. There are a handful of packages for which patching the build is needed.

Not having DESTDIR support seriously complicates the job of package maintainers regardless of packaging system.

This exact use case is described in the automake manual: http://www.gnu.org/software/automake/manual/html_node/DESTDIR.html

This install.sh isn't quite correct. It won't put the ${PKG}.conf files in the correct location. I have a hackish one-off solution that depends on the version of GHC, but I'm sure you folks can outdo my naive hacks.

I will add it as a patch to the PKGSRC package build, but I'd be much happier to have it in upstream.

Please integrate this fix.

Changed 11 months ago by AlainODea

PKGSRC patch for scripts/install.sh (works only for GHC 7.6.3)

Note: See TracTickets for help on using tickets.