Opened 4 years ago

Last modified 4 years ago

#10385 new bug

Annotation restriction is not respected while generating Annotation via TH

Reported by: simonpj Owned by: alanz
Priority: normal Milestone:
Component: Template Haskell Version: 7.10.1
Keywords: Cc:
Operating System: Unknown/Multiple Architecture: Unknown/Multiple
Type of failure: None/Unknown Test Case:
Blocked By: Blocking:
Related Tickets: Differential Rev(s):
Wiki Page:

Description

Magesh B writes: As per user guide one of the restriction in annotating value is the binder being annotated must be declared in the current module.

But when I use TH to generate the annotation above restriction is not respected. Below is the minimal test case to reproduce the issue

---- Ann.hs

{-# LANGUAGE TemplateHaskell #-}
module Ann where

import Language.Haskell.TH

-- {-# Ann id "Orphan Ann for id" #-}  -- Rightly produces error "Not in scope: ‘id’"

$(pragAnnD (ValueAnnotation 'id) [|"Orphan Ann for id"|] >>= return . return) -- Ideally this should have produced same error as above
---- End of Ann.hs

---- Main.hs

{-# LANGUAGE TemplateHaskell #-}
module Main where

import Ann ()
import Language.Haskell.TH

ann :: [String]
ann = $((reifyAnnotations (AnnLookupName 'id) :: Q [String]) >>= (\anns -> [|anns|]))

--err = 'a' && True  -- Uncomment to introduce compile error

main :: IO ()
main = print ann
 
---- End of Main.hs

Also there is another bug in reifying the Orphan Annotations. In the above example Main.hs depends on Ann.hs which defines Annotation for id When Main.hs compiles fine in the first go, its is able to retrieve the annotation for id Instead, if Ann.hs compiled successfully and Main.hs failed to compile and when you later fix the Main.hs error, it is not able to retrieve that annotation without recompiling Ann.hs

Change History (3)

comment:1 Changed 4 years ago by ezyang

Owner: set to alanz

Alan, could you take a look?

comment:2 Changed 4 years ago by alanz

I could look, but it is outside my area of expertise.

There are two different kinds of Annotations in GHC, the API Annotations which I brought in, and these ones.

comment:3 Changed 4 years ago by goldfire

Component: CompilerTemplate Haskell
Note: See TracTickets for help on using tickets.