Opened 4 years ago

Closed 4 years ago

#10422 closed bug (fixed)

reorder in nativeCodeGen too slow

Reported by: nomeata Owned by: nomeata
Priority: normal Milestone: 7.10.2
Component: Compiler (CodeGen) Version: 7.10.1
Keywords: Cc: simonmar
Operating System: Unknown/Multiple Architecture: Unknown/Multiple
Type of failure: None/Unknown Test Case:
Blocked By: Blocking:
Related Tickets: Differential Rev(s): Phab:D893
Wiki Page:


When working on #10397 and after fixing the bottleneck in elimCommonBlocks I noticed that reorder was taking most of the time. Bad lazy linked lists.

I have a fix, will put it on Phabricator for validation shortly

Change History (5)

comment:1 Changed 4 years ago by nomeata

Differential Rev(s): Phab:D893
Status: newpatch

comment:2 Changed 4 years ago by Joachim Breitner <mail@…>

In 8e4dc8fb63b8d3bfee485c1c830776f3ed704f4d/ghc:

Greatly speed up nativeCodeGen/seqBlocks

When working on #10397, I noticed that "reorder" in
nativeCodeGen/seqBlocks took more than 60% of the time. With this
refactoring, it does not even show up in the profile any more. This
fixes #10422.

Differential Revision:

comment:3 Changed 4 years ago by nomeata

Status: patchmerge

carter suggested that this might be 7.10 material.

comment:4 Changed 4 years ago by carter

Milestone: 7.10.2

this should be on the table for 7.10.2

comment:5 Changed 4 years ago by thoughtpolice

Resolution: fixed
Status: mergeclosed

Merged to ghc-7.10.

Note: See TracTickets for help on using tickets.