Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#10479 closed bug (fixed)

Make GHC install libraries to, e.g. xhtml-3000.2.1-0ACfOp3hebWD9jGWE4v4Gh

Reported by: ezyang Owned by: ezyang
Priority: high Milestone: 7.10.2
Component: Package system Version: 7.10.1
Keywords: Cc:
Operating System: Unknown/Multiple Architecture: Unknown/Multiple
Type of failure: None/Unknown Test Case:
Blocked By: Blocking: #9506
Related Tickets: Differential Rev(s): Phab:D922
Wiki Page:

Description

The GHC version of https://github.com/haskell/cabal/issues/2437 ; we need to adapt ghc-cabal to use the correct install paths. I have an in-flight patch, see the Phabricator. However, applying the change to HEAD is blocked by https://github.com/haskell/cabal/issues/2638 since there are some Cabal changes, which necessitate updating to Cabal head.

Cabal maintainers have expressed interest in this being merged into 7.10. To do this, we first have to merge the Cabal change into the 7.10 branch of Cabal, and apply the differential to GHC 7.10. (We shouldn't be blocked by the Cabal HEAD changes as those are not on the 7.10 branch.) If 7.10 release managers agree to let this patch in I volunteer to coordinate the changes.

Change History (6)

comment:1 Changed 4 years ago by ezyang

Blocking: 9506 added

comment:2 Changed 4 years ago by thoughtpolice

Priority: normalhigh

Bumping (similar to #10480, which requires an update, too).

comment:3 Changed 4 years ago by thoughtpolice

Status: newpatch

comment:4 Changed 4 years ago by ezyang

Fix is in the 1.22 Cabal branch, all we need is for Cabal to cut a release.

comment:5 Changed 4 years ago by thoughtpolice

Resolution: fixed
Status: patchclosed

Merged to ghc-7.10 - the RC will ship these bugfixes, but we don't have to wait on a release from them. I'm going to go ahead and close this; next week we'll comb over the libraries and update them to their final release.

comment:6 Changed 4 years ago by Edward Z. Yang <ezyang@…>

In 85d539754ac07286ef5fed714ad42451bd5a1d28/ghc:

Make GHC install libraries to e.g. xhtml-3000.2.1-0ACfOp3hebWD9jGWE4v4Gh.

Summary:
Previously, we'd install them to something like
xhtml_0ACfOp3hebWD9jGWE4v4G which was fairly ugly; this
commit changes the default install path to contain the full
package name and version, as well as the package key.

Needs a Cabal submodule update for the commit for install paths support
"Add libname install-dirs variable, use it by default. Fixes #2437".
It also contains some miscellaneous fixes for Cabal HEAD.

Signed-off-by: Edward Z. Yang <ezyang@cs.stanford.edu>

Test Plan: validate

Reviewers: austin

Subscribers: bgamari, thomie

Trac Issues: #10479

Differential Revision: https://phabricator.haskell.org/D922
Note: See TracTickets for help on using tickets.