Opened 4 years ago

Closed 4 years ago

Last modified 11 months ago

#10551 closed bug (fixed)

dynwrapper points to wrong paths on Windows

Reported by: ezyang Owned by: ezyang
Priority: normal Milestone: 7.10.2
Component: Build System (make) Version: 7.10.2-rc1
Keywords: Cc:
Operating System: Windows Architecture: Unknown/Multiple
Type of failure: None/Unknown Test Case:
Blocked By: Blocking:
Related Tickets: Differential Rev(s): Phab:D1001
Wiki Page:

Description

I was looking at build-prog.mk and I noticed this:

>-------echo 'LPTSTR path_dirs[] = {' >> $$@
>-------$$(foreach p,$$($1_$2_TRANSITIVE_DEP_KEYS),$$(call make-command,echo '    TEXT("/../lib/$$p")$$(comma)' >> $$@))
>-------echo '    TEXT("/../lib/"),' >> $$@
>-------echo '    NULL};' >> $$@
>-------echo 'LPTSTR progDll = TEXT

This probably can't be right since we're now using LIB_NAME to refer to filepaths. Better fix this...

Change History (6)

comment:1 Changed 4 years ago by thomie

Component: CompilerBuild System

No rush. DYNAMIC_GHC_PROGRAMS=NO on Windows (#5987), so this condition is never satisfied:

ifeq "$$(Windows_Host) $$($1_$2_PROGRAM_WAY)" "YES dyn"

Which means that that code is never used.

comment:2 Changed 4 years ago by ezyang

Priority: highnormal

Lowering priority.

comment:3 Changed 4 years ago by ezyang

Differential Rev(s): Phab:D1001

comment:4 Changed 4 years ago by Edward Z. Yang <ezyang@…>

In 6c5a66a225fcd65eb3abe32cc2128b0b90440451/ghc:

Fix #10551 by using LIB_NAMES.

Summary:
(NB: this code is dead at the moment since Windows is not built
dynamically.)

Signed-off-by: Edward Z. Yang <ezyang@cs.stanford.edu>

Test Plan: none

Reviewers: austin

Subscribers: thomie, bgamari

Differential Revision: https://phabricator.haskell.org/D1001

GHC Trac Issues: #10551

comment:5 Changed 4 years ago by ezyang

Resolution: fixed
Status: newclosed

comment:6 Changed 11 months ago by bgamari

Component: Build SystemBuild System (make)

The new Hadrian build system has been merged. Relabeling the tickets concerning the legacy make build system to prevent confusion.

Note: See TracTickets for help on using tickets.