Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#11003 closed bug (fixed)

Suggested fix for incorrect directory permissions is wrong

Reported by: dfeuer Owned by:
Priority: high Milestone: 7.10.3
Component: GHCi Version: 7.10.2
Keywords: Cc:
Operating System: Unknown/Multiple Architecture: Unknown/Multiple
Type of failure: Incorrect warning at compile-time Test Case:
Blocked By: Blocking:
Related Tickets: #8248 Differential Rev(s): Phab:D1350
Wiki Page:

Description

If the current directory is group- or world- writable, I get an error

*** WARNING: /home/blahblah/src/yproj is writable by someone else, IGNORING!
Suggested fix: execute 'chmod 644 /home/blahblah/src/yproj'

This is extremely bad advice, because 644 = rw-r--r--, meaning the directory is not executable, so nothing it contains can be accessed, and a user who's insufficiently familiar with Unix permissions will be very confused. The message should instead suggest 755=rwxr-xr-x.

Change History (5)

comment:1 Changed 4 years ago by bgamari

Differential Rev(s): Phab:D1350
Status: newpatch

comment:2 Changed 4 years ago by thomie

comment:3 Changed 4 years ago by Ben Gamari <ben@…>

In 0ae6a43/ghc:

Suggest chmod 755 instead of 644

Previous suggestion would clear executable bit, meaning directory
couldn't be entered. Fixes #11003.

Test Plan: Read message.

Reviewers: austin, thomie, dfeuer

Reviewed By: thomie, dfeuer

Subscribers: thomie

Differential Revision: https://phabricator.haskell.org/D1350

GHC Trac Issues: #11003

comment:4 Changed 4 years ago by bgamari

Resolution: fixed
Status: patchclosed

comment:5 Changed 4 years ago by bgamari

Also merging to ghc-7.10.

Note: See TracTickets for help on using tickets.