Opened 4 years ago

Closed 4 years ago

#11127 closed task (fixed)

Update cabal submodule to 1.22.5

Reported by: lukexi Owned by:
Priority: high Milestone: 7.10.3
Component: libraries (other) Version:
Keywords: Cc:
Operating System: Unknown/Multiple Architecture: Unknown/Multiple
Type of failure: None/Unknown Test Case:
Blocked By: Blocking:
Related Tickets: Differential Rev(s):
Wiki Page:

Description (last modified by lukexi)

For 7.10.3, this will fold in a critical fix for Mac (the Cabal side of #10568), along with a fix to prevent c-sources from being recompiled unnecessarily (a big deal when working with large C/C++ bindings).

The commit is fb7ce39

https://github.com/haskell/cabal/tree/1.22

Change History (12)

comment:1 Changed 4 years ago by lukexi

Description: modified (diff)

comment:2 Changed 4 years ago by bgamari

Resolution: wontfix
Status: newclosed

7.10.3 is a minor release before the quite major 8.0 and consequently we are trying to keep the delta small. This desire, coupled with the fact that Cabal can be easily updated after installation, convinced me that the potential risk that a bump (which involves more than 20k lines of changes) would carry outweighs the relatively minor benefits. Sorry!

comment:3 Changed 4 years ago by refold

IMO, bumping the Cabal version from 1.22.4.0 to 1.22.5.0 for a minor GHC release is a sensible thing to do. Cabal version was bumped for the 7.10.2 release as well. The diff is much smaller than 20K and contains only bugfixes.

Last edited 4 years ago by refold (previous) (diff)

comment:4 Changed 4 years ago by refold

Basically, the only changes in Cabal 1.22.5.0 are:

So I vote for bumping Cabal version from 1.22.4.0 to 1.22.5.0 for the 7.10.3 release.

Last edited 4 years ago by refold (previous) (diff)

comment:5 Changed 4 years ago by lukexi

Description: modified (diff)
Resolution: wontfix
Status: closednew
Summary: Update cabal submodule to 1.22 branch HEADUpdate cabal submodule to 1.22.5
Type: bugtask

Hi Ben,

I'll assume you misread the title and thought I was asking for a bump to Cabal actual HEAD, since that is indeed a 22K line diff : ). This is just a bump from 1.22.4 to 1.22.5 and it's about 58 lines.

https://github.com/haskell/cabal/compare/75266d2222eeefccfc26f28ca5d6c2dccf6de73f...1.22

I'll go ahead and reopen this based on that assumption, hope that's not rude : ).

Mikhail tagged a 1.22.5 release so the relevant commit is now fb7ce39.

Last edited 4 years ago by lukexi (previous) (diff)

comment:6 Changed 4 years ago by lukexi

(oops, I meant fb7ce39)

comment:7 in reply to:  5 Changed 4 years ago by hvr

Replying to lukexi:

Mikhail tagged a 1.22.5 release so the relevant commit is now fb7ce39.

nope, he didn't...

there's no git-signed annotated Git tag Cabal-v1.22.5.0 yet (like there was for http://git.haskell.org/packages/Cabal.git/tag/Cabal-v1.22.4.0)

comment:8 Changed 4 years ago by refold

Yes, I just bumped the version in the .cabal file. If you want Cabal 1.22.5.0 to be released on Hackage first, I'll ask Ryan to cut a release.

comment:9 Changed 4 years ago by bgamari

Resolution: wontfix
Status: newclosed

I asked Mikhail and then Ryan to tag a release last week. Sadly this still hasn't happened and I really can't afford to push 7.10.3 off any farther given the proximity of 8.0. Sorry Luke, I'm afraid I won't be able to fulfill this request.

comment:10 Changed 4 years ago by refold

I've just got a mail from Ryan and he says that he'll do a release today.

comment:11 Changed 4 years ago by refold

Resolution: wontfix
Status: closednew

Cabal-1.22.5.0 has just been released.

comment:12 Changed 4 years ago by bgamari

Resolution: fixed
Status: newclosed

Indeed, I managed to pull in the updated submodule before tagging the release. Looks like 7.10.3 will have a functional cabal afterall. Thanks for your patience everyone!

Note: See TracTickets for help on using tickets.