Opened 4 years ago

Closed 3 years ago

#12118 closed bug (fixed)

Testsuite driver does not normalise platform-dependent .stdout/stderr files

Reported by: thomie Owned by:
Priority: normal Milestone: 8.0.2
Component: Test Suite Version: 8.0.1
Keywords: Cc:
Operating System: Unknown/Multiple Architecture: Unknown/Multiple
Type of failure: None/Unknown Test Case:
Blocked By: Blocking:
Related Tickets: Differential Rev(s): Phab:D2267
Wiki Page:

Description

This change was made without explanation in commit 429f0099ab9adfadc779ca76f3aae1c9c160fb8c:

Author: Esa Ilari Vuokko <ei@vuokko.info>
Date:   Sun Aug 13 12:46:49 2006 +0000

    Fix driver not to normalise output when using platform specific output files

I don't understand why that change was made. It makes T11223_link_order_a_b_2_fail and T11223_simple_duplicate_lib fail on Windows, when running with BINDIST=YES (or, after accepting the BINDIST=YES output, when running with BINDIST=NO).

Change History (4)

comment:1 Changed 4 years ago by thomie

Differential Rev(s): Phab:D2267
Milestone: 8.0.2
Status: newpatch

comment:2 Changed 4 years ago by Thomas Miedema <thomasmiedema@…>

In 6a5bce14/ghc:

Testsuite: also normalise platform-dependent .stdout/stderr

This effectively reverses commit
429f0099ab9adfadc779ca76f3aae1c9c160fb8c (2006).

I don't see why platform-dependent .stdout/stderr files should //not//
get normalised.

It fixes T11223_link_order_a_b_2_fail on Windows, by normalising
`ghc-stage2.exe` to `ghc` when comparing stderr with .stderr-mingw32.

Reviewed by: Phyx

Differential Revision: https://phabricator.haskell.org/D2267

GHC Trac Issues: #12118

comment:3 Changed 4 years ago by thomie

Status: patchmerge

comment:4 Changed 3 years ago by bgamari

Resolution: fixed
Status: mergeclosed
Note: See TracTickets for help on using tickets.