Opened 3 years ago

Closed 3 years ago

Last modified 14 months ago

#12981 closed bug (fixed)

SMP never enabled on ARMv7

Reported by: orion Owned by:
Priority: normal Milestone: 8.0.2
Component: Build System (make) Version: 8.0.1
Keywords: Cc:
Operating System: Unknown/Multiple Architecture: arm
Type of failure: Building GHC failed Test Case:
Blocked By: Blocking:
Related Tickets: Differential Rev(s):
Wiki Page:

Description

SMP support should be enabled on ARMv7, however I have been unable to force it so. The problem lies in mk/config.mk.in, where double quotes have been erroneously added around the ArchSupportsSMP variable. This causes the GhcWithSMP variable to always be NO when building for ARM.

Attachments (1)

smp-arm-fix.patch (574 bytes) - added by orion 3 years ago.

Download all attachments as: .zip

Change History (5)

Changed 3 years ago by orion

Attachment: smp-arm-fix.patch added

comment:1 Changed 3 years ago by Sergei Trofimovich <siarheit@…>

In 52c5e55/ghc:

mk/config.mk.in: enable SMP on ARMv7+ (Trac #12981)

Before the change result of expression
    ArchSupportsSMP="$(if $(filter $(ARM_ISA),ARMv5 ARMv6),NO,YES)"
to evaluate to
    ArchSupportsSMP="YES"

After the change it's
    ArchSupportsSMP=YES

Thanks to orion for the fix!

Fixes Trac #12981
Signed-off-by: Sergei Trofimovich <siarheit@google.com>

comment:2 Changed 3 years ago by slyfox

Milestone: 8.0.2
Status: newmerge

Nice catch! The fix is worth backporting to 8.0.

comment:3 Changed 3 years ago by bgamari

Resolution: fixed
Status: mergeclosed

comment:4 Changed 14 months ago by bgamari

Component: Build SystemBuild System (make)

The new Hadrian build system has been merged. Relabeling the tickets concerning the legacy make build system to prevent confusion.

Note: See TracTickets for help on using tickets.