Opened 2 years ago

Last modified 8 months ago

#13897 upstream task

Ship check-ppr in bindist and compile during testsuite run

Reported by: bgamari Owned by: alanz
Priority: high Milestone: 8.8.1
Component: Compiler Version: 8.0.1
Keywords: continuous integration, newcomer Cc: alanz
Operating System: Unknown/Multiple Architecture: Unknown/Multiple
Type of failure: None/Unknown Test Case:
Blocked By: Blocking: #13716
Related Tickets: Differential Rev(s): Phab:D4039
Wiki Page:

Description

Currently check-ppr is built during the compiler build and used by the testsuite in the pretty-printer tests. In a source checkout this is fine, however this arrangement blows up in the case of a binary distribution as we don't (and probably shouldn't) ship the check-ppr binary in the bindist.

I think the most reasonable way to deal with this is to instead ship the check-ppr source (perhaps in the testsuite tarball) and build it as a dependency of the testsuite. Ideally we would build the executable once and use it for each of the ppr tests.

Change History (12)

comment:1 Changed 2 years ago by alanz

Owner: set to alanz

I will give it a go.

comment:2 Changed 2 years ago by bgamari

I should note that the same dilemma applies to check-api-annotations.

comment:3 Changed 2 years ago by bgamari

Blocking: 13716 added

comment:4 Changed 2 years ago by bgamari

Differential Rev(s): Phab:D4039
Status: newpatch

comment:5 Changed 2 years ago by Ben Gamari <ben@…>

In 1e9f90af/ghc:

Move check-ppr and check-api-annotations to testsuite/utils

These are needed by the testsuite and consequently must be shipped in
the testsuite tarball to ensure that we can test binary distributions.

See #13897.

Test Plan: Validate

Reviewers: austin

Subscribers: snowleopard, rwbarton, thomie

GHC Trac Issues: #13897

Differential Revision: https://phabricator.haskell.org/D4039

comment:6 Changed 2 years ago by bgamari

This also needs to be done in Hadrian.

comment:7 Changed 23 months ago by bgamari

Status: patchupstream

comment:8 Changed 21 months ago by bgamari

I have had to revert comment:5 due to #14392. I'm just going to focus on make this doable from Hadrian in the future.

comment:9 Changed 19 months ago by bgamari

Milestone: 8.4.18.6.1

This ticket won't be resolved in 8.4; remilestoning for 8.6. Do holler if you are affected by this or would otherwise like to work on it.

comment:10 Changed 13 months ago by bgamari

Keywords: continuous integration added
Milestone: 8.6.18.8.1

comment:11 Changed 9 months ago by bgamari

Keywords: newcomer added

comment:12 Changed 8 months ago by bgamari

Priority: normalhigh

Let's try to fix this in Hadrian.

Note: See TracTickets for help on using tickets.