Opened 21 months ago

Closed 21 months ago

Last modified 18 months ago

#14658 closed bug (fixed)

'Fix two more bugs in partial signatures' broke T10846

Reported by: niteria Owned by: simonpj
Priority: normal Milestone:
Component: Compiler Version:
Keywords: PartialTypeSignatures Cc:
Operating System: Unknown/Multiple Architecture: Unknown/Multiple
Type of failure: None/Unknown Test Case:
Blocked By: Blocking:
Related Tickets: Differential Rev(s):
Wiki Page:

Description

=====> T10846(normal) 1 of 1 [0, 0, 0]     
cd "./typecheck/should_run/T10846.run" &&  "/home/niteria/ghc-allocate-tyids/inplace/test   spaces/ghc-stage2" -o T10846 T10846.hs -dcore-lint -dcmm-lint -no-user-package-db -rtsopts -fno-warn-missed-specialisations -fshow-warning-groups -fdiagnostics-color=never -fno-diagnostics-show-caret -dno-debug-output                                       
cd "./typecheck/should_run/T10846.run" && ./T10846                                     
Actual stdout output differs from expected:                                            
diff -uw "./typecheck/should_run/T10846.run/T10846.stdout.normalised" "./typecheck/should_run/T10846.run/T10846.run.stdout.normalised"                                        
--- ./typecheck/should_run/T10846.run/T10846.stdout.normalised  2018-01-10 13:39:29.720468420 +0000                                                                           
+++ ./typecheck/should_run/T10846.run/T10846.run.stdout.normalised      2018-01-10 13:39:29.720468420 +0000                                                                   
@@ -1,3 +1,3 @@                            
 [18]                                      
-[19]                                      
-[20]                                      
+[]                                        
+[]                                        
*** unexpected failure for T10846(normal)  


Harbormaster results: https://phabricator.haskell.org/harbormaster/build/39597/

Reverting fixed it for me locally.

Change History (5)

comment:1 Changed 21 months ago by niteria

Owner: set to simonpj

comment:2 Changed 21 months ago by simonpj

Ugh. Validate obviously didn't run that test. Fix validating now.

comment:3 Changed 21 months ago by Simon Peyton Jones <simonpj@…>

In f3f90a07/ghc:

Fix previous patch

This recent patch
    commit 1577908f2a9db0fcf6f749d40dd75481015f5497
    Author: Simon Peyton Jones <simonpj@microsoft.com>
    Date:   Tue Jan 9 16:20:46 2018 +0000

        Fix two more bugs in partial signatures

        These were shown up by Trac #14643

failed validation for typecheck/should_run/T10846
(Reported in Trac #14658.)

The fix is simple.

comment:4 Changed 21 months ago by simonpj

Resolution: fixed
Status: newclosed

Sorry about that.

comment:5 Changed 18 months ago by simonpj

Keywords: PartialTypeSignatures added
Note: See TracTickets for help on using tickets.