Opened 10 months ago

Closed 9 months ago

#16003 closed bug (fixed)

Average and maximum residency numbers in nofib broken

Reported by: sgraf Owned by:
Priority: normal Milestone:
Component: NoFib benchmark suite Version: 8.6.2
Keywords: Cc:
Operating System: Unknown/Multiple Architecture: Unknown/Multiple
Type of failure: None/Unknown Test Case:
Blocked By: Blocking:
Related Tickets: #5793 Differential Rev(s): Phab:D5418
Wiki Page:

Description

Measuring average and maximum residency in nofib is currently broken:

<<ghc: 55717832 bytes, 32 GCs (29 + 3), 0/0 avg/max bytes residency (0 samples), 58859672 bytes GC work, ...

I think that this line in runstdtest.prl was responsible for matching on -S output, but since this commit, we only do -s for performance reasons. There's this bit of outcommented code that probably does what we want.

It seems that residency numbers were the only metrics depending on -S. I don't think there's a way to recover average residency with -s alone.

Change History (4)

comment:1 Changed 10 months ago by sgraf

comment:2 Changed 10 months ago by sgraf

Differential Rev(s): Phab:D5418
Status: newpatch

comment:3 Changed 10 months ago by Sebastian Graf <sebastian.graf@…>

In f352131/nofib:

Fix parsing of maximum residency in runstdtest

Summary:
`runstdtest` switched from `-S` to `-s` output a while ago.
That broke parsing of maximum and average residency numbers.

This commit makes sure that at least maximum residency is parsed
correctly from `-s` output, while leaving the logic for `-S` output.

Reviewers: simonmar, bgamari, simonpj, osa1, AndreasK, O26 nofib

Reviewed By: bgamari

GHC Trac Issues: #16003

Differential Revision: https://phabricator.haskell.org/D5418

comment:4 Changed 9 months ago by bgamari

Resolution: fixed
Status: patchclosed
Note: See TracTickets for help on using tickets.