Opened 8 months ago

Last modified 4 months ago

#16062 new task

Improve -dynamic-too progress messages

Reported by: osa1 Owned by:
Priority: lowest Milestone:
Component: Compiler Version: 8.7
Keywords: newcomer Cc:
Operating System: Unknown/Multiple Architecture: Unknown/Multiple
Type of failure: None/Unknown Test Case:
Blocked By: Blocking:
Related Tickets: Differential Rev(s):
Wiki Page:

Description

With -dynamic-too we run the code generator twice and generate two object files: .o and .o_dyn. However the progress messages do not reflect that:

$ ghc Main.hs -dynamic-too
[1 of 1] Compiling Lib              ( Main.hs, Main.o )

I think a better message would be:

[1 of 1] Compiling Lib              ( Main.hs, Main.o, Main.dyn_o )

Change History (2)

comment:1 Changed 8 months ago by adamse

Here are some notes:

The list of files seems to be produced by showModMsg in main/HscTypes.hs. It uses ModLocation{ml_obj_file} to say which .o file we're compiling. There is no corresponding ml_dyn_obj_file but the name could perhaps be reconstructed using ml_obj_file and dynObjectSuf from dflags.

comment:2 Changed 4 months ago by Marge Bot <ben+marge-bot@…>

In 57eb5bc/ghc:

Show dynamic object files (#16062)

Closes #16062. When -dynamic-too is specified, reflect that in the
progress message, like:

$ ghc Main.hs -dynamic-too
[1 of 1] Compiling Lib              ( Main.hs, Main.o, Main.dyn_o )

instead of:

$ ghc Main.hs -dynamic-too
[1 of 1] Compiling Lib              ( Main.hs, Main.o )
Note: See TracTickets for help on using tickets.