Opened 7 months ago

Last modified 6 months ago

#16265 merge bug

API Annotations: parens anns discarded for `(*)` operator

Reported by: alanz Owned by: alanz
Priority: normal Milestone: 8.8.1
Component: Compiler (Parser) Version: 8.6.3
Keywords: Cc:
Operating System: Unknown/Multiple Architecture: Unknown/Multiple
Type of failure: Incorrect API annotation Test Case:
Blocked By: Blocking:
Related Tickets: Differential Rev(s):
Wiki Page:

Description

The patch from https://phabricator.haskell.org/D4865 introduces

    go _ (HsParTy _ (dL->L l (HsStarTy _ isUni))) acc ann fix
      = do { warnStarBndr l
           ; let name = mkOccName tcClsName (if isUni then "★" else "*")
           ; return (cL l (Unqual name), acc, fix, ann) }

which discards the parens annotations belonging to the HsParTy.

Change History (4)

comment:1 Changed 7 months ago by alanz

Owner: set to alanz

comment:3 Changed 7 months ago by alanz

Status: newmerge

comment:4 Changed 6 months ago by Marge Bot <ben+marge-bot@…>

In 5e9888b/ghc:

API Annotations: parens anns discarded for `(*)` operator

The patch from https://phabricator.haskell.org/D4865 introduces

    go _ (HsParTy _ (dL->L l (HsStarTy _ isUni))) acc ann fix
      = do { warnStarBndr l
           ; let name = mkOccName tcClsName (if isUni then "★" else "*")
           ; return (cL l (Unqual name), acc, fix, ann) }

which discards the parens annotations belonging to the HsParTy.

Updates haddock submodule

Closes #16265
Note: See TracTickets for help on using tickets.