Opened 9 years ago

Closed 9 years ago

Last modified 5 years ago

#4489 closed bug (fixed)

The new flag -fwarn-missing-import-lists does not recognize the (..) form of import.

Reported by: andressr Owned by:
Priority: normal Milestone: 7.4.1
Component: Compiler Version:
Keywords: Cc: asr
Operating System: Unknown/Multiple Architecture: Unknown/Multiple
Type of failure: None/Unknown Test Case: rename/should_compile/T4489
Blocked By: Blocking:
Related Tickets: Differential Rev(s):
Wiki Page:

Description

When using the (..) form of import and the new flag -fwarn-missing-import-lists, for example

import Foo ( A(..) )

GHC 7.0.0 RC2 yields the warning

Test.hs:1:1:
    Warning: The module `Foo' does not have an explicit import list

Change History (7)

comment:1 Changed 9 years ago by igloo

Milestone: 7.2.1

Thanks for the report.

comment:2 Changed 9 years ago by simonpj

Resolution: fixed
Status: newclosed
Test Case: rename/should_compile/T4489

Good point. Fixed by

Mon Nov 15 23:21:42 GMT Standard Time 2010  simonpj@microsoft.com
  * Fix -fwarn-missing-import-lists (fix Trac #4489)

    M ./compiler/rename/RnNames.lhs -9 +14
    M ./docs/users_guide/flags.xml -1 +2

Simon

comment:3 Changed 9 years ago by andressr

Thanks for fix the bug.

In the original report I did not include my email address in the CC field because I was not logged as guest, however I did not receive an email notification about the changes. Should I have used the CC field?

comment:4 Changed 9 years ago by andressr

Oops, please forget my question about the CC field. I received the email notifications.

comment:5 Changed 8 years ago by asr

Cc: andres.sicard.ramirez@… added

FTI, GHC 7.4.1 RC1 (7.4.0.20111219) has the same behavior.

comment:6 Changed 8 years ago by simonpj

difficulty: Unknown

| FTI, GHC 7.4.1 RC1 (7.4.0.20111219) has the same behavior.

I don't think so. For this code

import Data.Maybe( Maybe(..) )

you get the message

T4489.hs:5:1:
    Warning: The import item `Maybe(..)' does not have an explicit import list

and that is absolutely right. If you say

import Data.Maybe

you get the (different) warning

T4489.hs:4:1:
    Warning: The module `Data.Maybe' does not have an explicit import list

So I think 7.4 is fine. Reopen if you disagree.

Simon

comment:7 Changed 5 years ago by asr

Cc: asr added; andres.sicard.ramirez@… removed
Note: See TracTickets for help on using tickets.