Opened 9 years ago

Closed 9 years ago

#4961 closed task (fixed)

Make the Timeout exception a newtype instead of a datatype

Reported by: basvandijk Owned by:
Priority: normal Milestone: 7.4.1
Component: libraries/base Version: 7.0.1
Keywords: Cc:
Operating System: Unknown/Multiple Architecture: Unknown/Multiple
Type of failure: None/Unknown Test Case:
Blocked By: Blocking:
Related Tickets: Differential Rev(s):
Wiki Page:

Description

The attached patch simply replaces the data with a newtype for the Timeout exception in System.Timeout:

-data    Timeout = Timeout Unique deriving Eq
+newtype Timeout = Timeout Unique deriving Eq

Attachments (1)

make_Timeout_a_newtype.dpatch (64.9 KB) - added by basvandijk 9 years ago.

Download all attachments as: .zip

Change History (5)

Changed 9 years ago by basvandijk

comment:1 Changed 9 years ago by simonmar

Milestone: 7.2.1
Owner: set to simonmar

Obviously good, thanks. I'll push.

comment:2 Changed 9 years ago by basvandijk

Resolution: invalid
Status: newclosed

Simon, I noticed you didn't push yet. That's good because, as you know, I'm working on a faster timeout which doesn't really need this patch. So please don't push so I can obliterate the patch in my repository and keep the darcs log clean.

Thanks!

comment:3 Changed 9 years ago by basvandijk

Owner: simonmar deleted
Resolution: invalid
Status: closednew

Since I wasn't able to speedup the existing timeout, I'm reopening this ticket.

Sorry for the noise.

comment:4 Changed 9 years ago by simonmar

Resolution: fixed
Status: newclosed

Pushed today:

Tue Feb 15 13:24:57 PST 2011  Bas van Dijk <v.dijk.bas@gmail.com>
  * Make the Timeout exception a newtype instead of a datatype
Note: See TracTickets for help on using tickets.