Opened 9 years ago

Closed 9 years ago

#5179 closed bug (fixed)

Unexpected Failure due to change of defaultDynFlags' type

Reported by: daniel.is.fischer Owned by: igloo
Priority: high Milestone: 7.2.1
Component: Test Suite Version: 7.1
Keywords: Cc:
Operating System: Unknown/Multiple Architecture: Unknown/Multiple
Type of failure: Other Test Case:
Blocked By: Blocking:
Related Tickets: Differential Rev(s):
Wiki Page:

Description

annrun01 fails with

annrun01.hs:18:28:
    Couldn't match expected type `DynFlags'
                with actual type `DynFlags.Settings -> DynFlags'
    In the first argument of `defaultErrorHandler', namely
      `defaultDynFlags'
    In the expression: defaultErrorHandler defaultDynFlags
    In the expression:
        defaultErrorHandler defaultDynFlags
      $   runGhc (Just cTop)

defaultDynFlags now takes an argument of type Settings, the test has not been updated yet.

Change History (5)

comment:1 Changed 9 years ago by daniel.is.fischer

Supplying undefined as argument for defaultDynFlags makes annrun01 pass. Giving reasonable Settings would be preferable, though.

comment:2 Changed 9 years ago by simonpj

Owner: set to igloo
Priority: normalhigh

Ian is taking this.

comment:3 Changed 9 years ago by simonpj

Milestone: 7.2.1

comment:4 Changed 9 years ago by daniel.is.fischer

defaultDynFlags now has argument (panic "No settings") and the test passes, should the ticket be closed or left open to find reasonable Settings?

comment:5 Changed 9 years ago by igloo

Resolution: fixed
Status: newclosed

Passing the panic is the right thing to do, for now at least.

(In the future, we might want defaultErrorHandler to take a smaller value instead, i.e. only the information it actually needs rather than all of DynFlags).

Note: See TracTickets for help on using tickets.