Opened 6 years ago

Closed 6 years ago

Last modified 5 years ago

#8302 closed feature request (fixed)

Add 'bool' to Data.Bool

Reported by: ocharles Owned by:
Priority: normal Milestone: 7.8.1
Component: libraries/base Version: 7.6.3
Keywords: report-impact Cc:
Operating System: Unknown/Multiple Architecture: Unknown/Multiple
Type of failure: None/Unknown Test Case:
Blocked By: Blocking:
Related Tickets: Differential Rev(s):
Wiki Page:


As mentioned in I propose we add the 'bool' function to 'Data.Bool'.

Attachments (1)

0001-Add-Data.Bool.bool-fixes-8302.patch (737 bytes) - added by ocharles 6 years ago.

Download all attachments as: .zip

Change History (11)

comment:1 Changed 6 years ago by ocharles

Status: newpatch

comment:2 Changed 6 years ago by ocharles

I have quickly whipped up a patch that adds the 'bool' function to 'Data.Bool'. This is my first contribution to GHC related stuff, so I may well have done things wrong - please let me know! Unfortunately, I am yet to build the above patch - I rushed this patch out due to the merge window closing on Monday; I will try and dedicate some time tomorrow to building it but if a reviewer already has a setup to do so, that may be quicker.

Changed 6 years ago by ocharles

comment:3 Changed 6 years ago by schyler

Punting for this.

comment:4 Changed 6 years ago by nomeata

Looking at this. Why the INLINE pragma? Neither maybe nor either has that.

comment:5 Changed 6 years ago by ocharles

No specific reason - I just tend to automatically add INLINE quite liberally to small definitions. I can remove it if you want; it might be better to be consistent with maybe and either.

comment:6 Changed 6 years ago by nomeata

Ok; validate is running right now (although I cannot imagine how it could fail due to this), will push afterwards.

comment:7 Changed 6 years ago by Joachim Breitner <mail@…>

In f404697486b1db27711be134fd65c6c5e60d7604/base:

Add Data.Bool.bool (fixes #8302)

comment:8 Changed 6 years ago by nomeata

Resolution: fixed
Status: patchclosed

comment:9 Changed 6 years ago by Joachim Breitner <mail@…>

In 5f212c866b704ee461e523563534c3a3fbe0735a/ghc:

Release Notes: Document Data.Bool.bool (#8302)

comment:10 Changed 5 years ago by hvr

Keywords: report-impact added
Note: See TracTickets for help on using tickets.