Opened 6 years ago

Closed 6 years ago

Last modified 6 years ago

#8718 closed task (fixed)

Add role annotations to base

Reported by: nomeata Owned by:
Priority: high Milestone: 7.8.1
Component: libraries/base Version: 7.8.1-rc2
Keywords: Cc: hvr
Operating System: Unknown/Multiple Architecture: Unknown/Multiple
Type of failure: None/Unknown Test Case:
Blocked By: Blocking: #8767
Related Tickets: Differential Rev(s):
Wiki Page:

Description

With roles and Coercible in GHC, we ought to add role annotations to base and other libraries. We have them for Ptr and FunPtr; I guess we need them for

  • Map (first parameter)
  • Set
  • Vector (or rather its primitive building block)

What else?

Change History (6)

comment:1 Changed 6 years ago by goldfire

See also a very relevant thread starting here: http://www.haskell.org/pipermail/libraries/2013-November/021707.html

comment:2 Changed 6 years ago by nomeata

Blocking: 8767 added

comment:3 Changed 6 years ago by Herbert Valerio Riedel <hvr@…>

In e55acf007f5109b42a2e388eaca63445bbbc7376/ghc:

Update to containers-0.5.5.0

This adds role annotations to Map and Set and therefore addresses #8718

Signed-off-by: Herbert Valerio Riedel <hvr@gnu.org>

comment:4 Changed 6 years ago by goldfire

Cc: hvr added
Resolution: fixed
Status: newclosed

Yes, this is all in good shape now, assuming the new containers ships with 7.8. Thanks.

comment:5 Changed 6 years ago by thoughtpolice

Version: 7.6.37.8.1-rc2

Yep, thanks Herbert!

comment:6 Changed 6 years ago by Herbert Valerio Riedel <hvr@…>

In df265b95a2f3640425b43b17993b9ec78a287f60/ghc:

Update to containers-0.5.5.1

This fixes a wrong #if around role annotations (see #8718)

Signed-off-by: Herbert Valerio Riedel <hvr@gnu.org>
Note: See TracTickets for help on using tickets.