Opened 6 years ago

Closed 4 years ago

Last modified 15 months ago

#9095 closed bug (fixed)

make sdist picks up test files

Reported by: ezyang Owned by: thomie
Priority: low Milestone: 8.2.1
Component: Build System (make) Version: 7.9
Keywords: Cc:
Operating System: Unknown/Multiple Architecture: Unknown/Multiple
Type of failure: None/Unknown Test Case:
Blocked By: Blocking:
Related Tickets: Differential Rev(s):
Wiki Page:

Description

I recently ran 'make sdist' and discovered that I my source tarball was nearly a gigabyte large. Closer inspection revealed that sdist had slurped up executable files for tests that I had run at some point. It would be preferable if 'make sdist' did not do that.

Change History (4)

comment:1 Changed 5 years ago by nomeata

Keywords: newcomer added

comment:2 Changed 5 years ago by thomie

Keywords: newcomer removed
Owner: set to thomie

comment:3 Changed 4 years ago by thomie

Milestone: 8.2.1
Resolution: fixed
Status: newclosed

Fixed by running tests in /tmp (#11980).

Although not perfect (if you yourself create some temporary files in the testsuite/ directory, they will still be included in the sdist. So just don't do that if you care about this issue.), I think it's good enough for now. Maybe Hadrian will do better.

comment:4 Changed 15 months ago by bgamari

Component: Build SystemBuild System (make)

The new Hadrian build system has been merged. Relabeling the tickets concerning the legacy make build system to prevent confusion.

Note: See TracTickets for help on using tickets.