Opened 5 years ago

Closed 4 years ago

Last modified 4 years ago

#9746 closed bug (fixed)

tests/ghci/scripts/T8172 is sensitive to drive name on Windows

Reported by: gintas Owned by:
Priority: normal Milestone: 8.0.1
Component: Test Suite Version: 7.8.3
Keywords: Cc:
Operating System: Windows Architecture: Unknown/Multiple
Type of failure: None/Unknown Test Case:
Blocked By: Blocking:
Related Tickets: Differential Rev(s):
Wiki Page:

Description (last modified by gintas)

The test fails when the checkout is not on drive C:, like this:

--- ./ghci/scripts/T8172.stdout-mingw32 2014-10-28 23:28:12.264410700 +0100
+++ ./ghci/scripts/T8172.run.stdout     2014-10-30 15:20:13.964595800 +0100
@@ -1,11 +1,11 @@
 current working directory:
-  C:\
+  K:\
 module import search paths:
   .
 current working directory:
-  C:\
+  K:\
 module import search paths: none
 current working directory:
-  C:\
+  K:\
 module import search paths:
   /

Change History (4)

comment:1 Changed 5 years ago by gintas

Description: modified (diff)

comment:2 Changed 5 years ago by simonpj

So, can we just fix the test, so that it is not sensitive in this way?

comment:3 Changed 4 years ago by thomie

Milestone: 7.12.1
Resolution: fixed
Status: newclosed

Ha. I fixed this today in da84fd5475d189c39bd3e12d29f45618c92ed800, not knowing this ticket existed.

Author: Thomas Miedema <thomasmiedema@gmail.com>
Date:   Thu Jun 11 19:26:11 2015 +0200

    Testsuite Windows: fix T8172 (#8172)
    
    Use the new function `normalise_drive_letter` to change D:\ to C:\
    before comparing outputs.

Any other letter is fine too.

comment:4 Changed 4 years ago by thoughtpolice

Milestone: 7.12.18.0.1

Milestone renamed

Note: See TracTickets for help on using tickets.