Opened 5 years ago

Closed 5 years ago

#9826 closed feature request (fixed)

add Storable Complex and Ratio instance to base library

Reported by: carter Owned by: carter
Priority: normal Milestone: 7.10.1
Component: libraries/base Version: 7.8.3
Keywords: Cc: hvr, ekmett
Operating System: Unknown/Multiple Architecture: Unknown/Multiple
Type of failure: None/Unknown Test Case:
Blocked By: Blocking:
Related Tickets: Differential Rev(s): Phab:D519
Wiki Page:

Description (last modified by carter)

per the libraries discussion + core libraries committee OK, I'm putting a phab differential up for adding Storable instances for Complex and Ratio

(and then noticing that theres basically NO tests for Storable except indirectly)

the libraries thread for Complex and Ratio https://www.haskell.org/pipermail/libraries/2014-November/024064.html

the thread on the CLC list https://groups.google.com/forum/#!topic/haskell-core-libraries/mjBSo2CQ3LU

Change History (5)

comment:1 Changed 5 years ago by carter

Differential Rev(s): Phab:D519
Status: newpatch

still need to add tests... but storable per se has no tests in base!

comment:2 Changed 5 years ago by hvr

please add links to the libraries/CLC discussion threads in the ticket-description

comment:3 Changed 5 years ago by carter

Description: modified (diff)

comment:4 Changed 5 years ago by Herbert Valerio Riedel <hvr@…>

In fb061c193947a7096471486faade1d0db30bc588/ghc:

Add `Storable` instances for `Complex` and `Ratio`

The actual type-signatures of the new instances are:

  instance Storable a => Storable (Complex a)

  instance (Storable a, Integral a) => Storable (Ratio a)

See also

  https://groups.google.com/d/msg/haskell-core-libraries/mjBSo2CQ3LU/0gwg0QvviOIJ

Addresses #9826

Reviewed By: ekmett

Differential Revision: https://phabricator.haskell.org/D519

comment:5 Changed 5 years ago by thoughtpolice

Resolution: fixed
Status: patchclosed
Note: See TracTickets for help on using tickets.