Opened 5 years ago

Closed 4 years ago

#9976 closed feature request (duplicate)

Ignore newlines in code diffs on Phab

Reported by: goldfire Owned by:
Priority: low Milestone:
Component: Trac & Git Version: 7.8.4
Keywords: Cc:
Operating System: Unknown/Multiple Architecture: Unknown/Multiple
Type of failure: None/Unknown Test Case:
Blocked By: Blocking:
Related Tickets: Differential Rev(s):
Wiki Page:


Doing code reviews in Phab is great. However, the way that the lint feature works encourages patchers to split lines as they means that more attention is drawn to split lines than perhaps should be.

As a concrete example, I'm reading Phab:D538 this morning, and looking at line 402 of DsArrows. Alan has added a new field to a data structure and needed to insert a _ to make the code remain well typed... but this forced a line split to avoid a lint error. Now, I have to check if there are any changes in the second half of the line manually, because the character-diff highlighting fails after the line split.

Is there a way to improve this behavior? I can think of two approaches:

  • (Better option) Teach the character-diff highlighting feature to look across linebreaks.
  • (Worse option) Encourage patchers not to make new line breaks until their final commit. Suppress lint problems about line breaks by request.

This is, of course, minor, but it would certainly be nice!

Change History (1)

comment:1 Changed 4 years ago by thomie

Resolution: duplicate
Status: newclosed
Note: See TracTickets for help on using tickets.