Changes between Version 16 and Version 17 of WorkingConventions/GitLabSPJ
- Timestamp:
- Feb 26, 2019 4:20:41 PM (10 months ago)
Legend:
- Unmodified
- Added
- Removed
- Modified
-
WorkingConventions/GitLabSPJ
v16 v17 67 67 == Merge requests == 68 68 69 * The title and description of a MRdo not form part of the Git repo's history. Only the commit messages in the patches do. So make sure that each patch has a good commit message! The title and description of the MR signpost the readers through the review process.69 * '''The title and description of a MR''' do not form part of the Git repo's history. Only the commit messages in the patches do. So make sure that each patch has a good commit message! The title and description of the MR signpost the readers through the review process. 70 70 71 71 * To see all merge requests, click on "Merge requests" ''in the left-hand nav column''. The similar icon in the black menu bar at the top doesn't seem to do anything useful. … … 77 77 * The "merge" button is disabled for WIP MRs, so they can't be accidentally merged. 78 78 Details [https://docs.gitlab.com/ee/user/project/merge_requests/work_in_progress_merge_requests.html here] 79 80 * '''Approvers'''. A MR requires at least one approver to press the "Approve" button before a MR will be merged. The approvers for a MR are drawn from three sources: 81 * A small per-project list of super-developers. 82 * The [https://gitlab.haskell.org/ghc/ghc/blob/master/CODEOWNERS code owners file]: if your patch touches code listed in this file, the corresponding users become approvers for that MR. 83 * Per-MR approvers, which you as MR author can add. ''From what list?''' 84 Per MR approvers: chosen from developer. 85 79 86 80 87 == Gitlab tips ==